Fix #2325 map viewer spining indefinitely when loading non-existent map issue #2327
Conversation
Summary of ChangesHello @subashtiwari1010, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug where the map viewer would enter an indefinite loading state when attempting to load a map that does not exist. By refining the error handling within the resource loading epic, the system can now properly acknowledge and react to missing map resources, thereby preventing the UI from getting stuck in an unresponsive spinning animation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the map viewer would spin indefinitely when trying to load a non-existent map. The fix correctly removes a .catch block that was swallowing errors, allowing them to propagate and be handled properly. This is a good change that improves error handling. However, the fix appears to be incomplete. The catch block in the gnViewerRequestResourceConfig epic (lines 573-578), which will now handle these propagated errors, does not dispatch an action to set loadingResourceConfig to false. The resourceConfigError action it dispatches only affects a different loading flag in the reducer. As a result, the loading spinner will likely persist even when an error occurs. To fully resolve the issue, loadingResourceConfig(false) should be dispatched within that catch block.
2 participants
Related task
Fixes #2325
Describe this PR
This PR fixes the issue of indefinite spinning when loading a non-existent map in the Map viewer.
